Formatting and sorting imports in Python files #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2022 10:50
Wrede
requested changes
May 30, 2022
There was a problem hiding this comment.
Please update https://github.com/scaleoutsystems/fedn/blob/develop/CONTRIBUTING.md
according to these changes. Also, include instructions for how to use the devcontainer.
|
@Wrede I have added contrib guidelines. I will add instruction for the devcontainer in a separated PR. |
ahellander
requested changes
May 31, 2022
| @@ -28,3 +28,11 @@ Report a bug or propose a feature by [opening a new GitHub Issue](https://github | |||
| - if your branch is a hotfix, name it **hotfix/[GitHub-Issue-ID]** | |||
|
|
|||
| Open your pull requests against the **develop** branch unless you're resolving a critical bug in production (hotfix). Then your pull request should be against **master** branch. | |||
|
|
|||
| ### Code checks | |||
| We defined GitHub actions that check code quality and formatting agains pushed branches and pull requests. We use: | |||
There was a problem hiding this comment.
Fixed in latest commit
Wrede
approved these changes
May 31, 2022
ahellander
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces mandatory formatting and sorting imports in Python files. If you develop in VS code devcontainer this is now done automatically on save. Otherwise, the same can be easily achieved with
autopep8andisortcommnads (as done in the GH actions).