pin bokeh dep, resolves #444, filter graph to only plot online client… #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 1, 2022
Wrede
approved these changes
Dec 2, 2022
| @@ -375,7 +376,8 @@ def network_graph(): | |||
| graph = plot.make_netgraph_plot(df_edges, df_nodes) | |||
| return json.dumps(json_item(graph, "myplot")) | |||
| except Exception: | |||
There was a problem hiding this comment.
why is there a try clause here if nothing is being handled?
There was a problem hiding this comment.
Good point, vill fix this in some future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filters network graph to only plot online clients.
Pins bokeh dependency to handle #444
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
-->