Feature/SK-1229 | Project resource for CLI extension #784
Conversation
KatHellg
changed the title
fedn/cli/login_cmd.py
Outdated
| @click.option("-H", "--host", required=False, default="fedn.scaleoutsystems.com", help="Hostname of controller (api)") | ||
| @click.option("-p", "--protocol", required=False, default=CONTROLLER_DEFAULTS["protocol"], help="Communication protocol of controller (api)") | ||
| @click.option("-H", "--host", required=False, default=CONTROLLER_DEFAULTS["host"], help="Hostname of controller (api)") | ||
| @click.option("-P", "--port", required=False, default=CONTROLLER_DEFAULTS["port"], help="Port of controller (api)") |
There was a problem hiding this comment.
skulle även vilja ha alternativet att kunna ange --user --password istället för promt
fedn/cli/login_cmd.py
Outdated
| else: | ||
| click.secho(f"Unexpected error: {response.text}", fg="red") | ||
|
|
||
|
|
||
| def get_context(response, protocol, host, port): |
There was a problem hiding this comment.
add doc string explaning what the function do, and in particular explain what context_data is.
fedn/cli/login_cmd.py
Outdated
| if not os.path.exists(context_path): | ||
| os.makedirs(context_path) | ||
| try: | ||
| with open(f"{context_path}/context.yaml", "w") as yaml_file: |
There was a problem hiding this comment.
vad händer om det redan finns en context.yaml med innehåll?
fedn/cli/login_cmd.py
Outdated
| headers_projects["Authorization"] = _token | ||
|
|
||
| try: | ||
| response_projects = requests.get(url_projects, headers=headers_projects) |
There was a problem hiding this comment.
om det returnerar status_code != 200 vad händer då?
fedn/cli/login_cmd.py
Outdated
| except requests.exceptions.ConnectionError: | ||
| click.echo(f"Error: Could not connect to {url_project_token}") | ||
|
|
||
| controller_url = f"{protocol}://{host}/{slug}-fedn-reducer" |
There was a problem hiding this comment.
istället för att hårdkoda url med "-fedn-reducer" bör den fullstädiga url till controller returneras av studio
fedn/cli/project_cmd.py
Outdated
| def list_projects(ctx, protocol: str = None, host: str = None, port: str = None, token: str = None): | ||
| """Return: | ||
| ------ | ||
| - result: list of packages |
fedn/cli/project_cmd.py
Outdated
| for i in response_json: | ||
| project_name = i.get("slug") | ||
| if project_name == active_project: | ||
| click.secho(project_name, fg="green") |
There was a problem hiding this comment.
skulle nog tom ha project_name + "(active)" för att vara ännu mer tydlig
fedn/cli/project_cmd.py
Outdated
| @click.option("-p", "--protocol", required=False, default=CONTROLLER_DEFAULTS["protocol"], help="Communication protocol of controller (api)") | ||
| @click.option("-H", "--host", required=False, default=CONTROLLER_DEFAULTS["host"], help="Hostname of controller (api)") | ||
| @click.option("-P", "--port", required=False, default=CONTROLLER_DEFAULTS["port"], help="Port of controller (api)") | ||
| @project_cmd.command("activate") |
There was a problem hiding this comment.
hmm "activate", kanske "fedn project set-context"? Bara en tanke
fedn/cli/project_cmd.py
Outdated
| context_data["Active project url"] = controller_url | ||
|
|
||
| try: | ||
| with open(f"{context_path}/context.yaml", "w") as yaml_file: |
There was a problem hiding this comment.
code redudancy, gör till utility metod
| @@ -16,6 +18,8 @@ | |||
|
|
|||
| API_VERSION = "v1" | |||
There was a problem hiding this comment.
detta måste funka för windows också, gör det det?
Features: