Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): update react monorepo to v18 (major) (#1314) #1642

Merged
merged 1 commit into from
Jun 28, 2022
Merged

feat(deps): update react monorepo to v18 (major) (#1314) #1642

merged 1 commit into from
Jun 28, 2022

Conversation

matthprost
Copy link
Collaborator

React 18 revert of the revert.

@matthprost matthprost added the enhancement New feature or request label Jun 28, 2022
@matthprost matthprost requested a review from chambo-e June 28, 2022 13:13
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/src/index.js, dist/react-datepicker/dist/react-datepicker.min.css.js, dist/react-toastify/dist/ReactToastify.min.css.js, dist/src/helpers/isJSON.js, dist/src/helpers/keycode.js, dist/src/helpers/legend.js, dist/src/helpers/numbers.js, dist/src/helpers/recursivelyGetChildrenString.js, dist/src/theme/index.js, dist/src/utils/animations.js, dist/src/utils/capitalize.js, dist/src/utils/ids.js, dist/src/utils/normalize.js, dist/src/utils/orderBy.js, dist/intl-tel-input/build/css/intlTelInput.css.js, dist/src/components/ActionBar/index.js, dist/src/components/Alert/index.js, dist/src/components/Avatar/index.js, dist/src/components/Badge/index.js, dist/src/components/BarChart/Tooltip.js, dist/src/components/BarChart/index.js, dist/src/components/BarStack/index.js, dist/src/components/BorderedBox/index.js, dist/src/components/Box/index.js, dist/src/components/Breadcrumbs/index.js, dist/src/components/Bullet/index.js, dist/src/components/Button/index.js, dist/src/components/Checkbox/index.js, dist/src/components/Container/index.js, dist/src/components/Counter/index.js, dist/src/components/DateInput/index.js, dist/src/components/Description/index.js, dist/src/components/DotSteps/index.js, dist/src/components/Expandable/index.js, dist/src/components/FlexBox/index.js, dist/src/components/Grid/Col.js, dist/src/components/Grid/Grid.js, dist/src/components/Grid/Row.js, dist/src/components/Icon/index.js, dist/src/components/Image/index.js, dist/src/components/Label/index.js, dist/src/components/LineChart/CustomLegend.js, dist/src/components/LineChart/Tooltip.js, dist/src/components/LineChart/helpers.js, dist/src/components/LineChart/index.js, dist/src/components/Link/index.js, dist/src/components/List/Cell.js, dist/src/components/List/SelectBar.js, dist/src/components/List/SortIcon.js, dist/src/components/List/context.js, dist/src/components/List/index.js, dist/src/components/List/variantExplorer.js, dist/src/components/List/variantProduct.js, dist/src/components/List/variantTable.js, dist/src/components/Loader/index.js, dist/src/components/MarkDown/index.js, dist/src/components/Menu/Item.js, dist/src/components/Menu/index.js, dist/src/components/Modal/index.js, dist/src/components/NavigationStepper/index.js, dist/src/components/Notice/index.js, dist/src/components/Pagination/getPageNumbers.js, dist/src/components/Pagination/index.js, dist/src/components/Pagination/usePagination.js, dist/src/components/PasswordCheck/index.js, dist/src/components/PasswordStrengthMeter/index.js, dist/src/components/Pentagon/index.js, dist/src/components/PhoneInput/flags.png.js, dist/src/components/PhoneInput/index.js, dist/src/components/PieChart/Legends.js, dist/src/components/PieChart/Tooltip.js, dist/src/components/PieChart/index.js, dist/src/components/PieChart/patterns.js, dist/src/components/Placeholder/Block.js, dist/src/components/Placeholder/Blocks.js, dist/src/components/Placeholder/BoxWithIcon.js, dist/src/components/Placeholder/Donut.js, dist/src/components/Placeholder/IconPlaceholder.js, dist/src/components/Placeholder/Line.js, dist/src/components/Placeholder/List.js, dist/src/components/Placeholder/Slider.js, dist/src/components/Placeholder/index.js, dist/src/components/ProgressBar/index.js, dist/src/components/ProgressionButton/index.js, dist/src/components/Radio/index.js, dist/src/components/RadioBorderedBox/index.js, dist/src/components/Range/index.js, dist/src/components/RichSelect/index.js, dist/src/components/ScrollView/index.js, dist/src/components/SelectNumber/index.js, dist/src/components/Separator/index.js, dist/src/components/Slider/index.js, dist/src/components/Sphere/index.js, dist/src/components/StateBar/index.js, dist/src/components/Status/index.js, dist/src/components/StatusIndicator/index.js, dist/src/components/StealthCopiable/index.js, dist/src/components/StepList/index.js, dist/src/components/Stepper/index.js, dist/src/components/Switch/index.js, dist/src/components/SwitchButton/index.js, dist/src/components/TabGroup/Tab.js, dist/src/components/TabGroup/index.js, dist/src/components/Table/index.js, dist/src/components/Tag/index.js, dist/src/components/Tags/index.js, dist/src/components/TagsPoplist/index.js, dist/src/components/Text/index.js, dist/src/components/TextBox/index.js, dist/src/components/TimeInput/index.js, dist/src/components/Toaster/index.js, dist/src/components/Tooltip/index.js, dist/src/components/TooltipIcon/index.js, dist/src/components/Touchable/index.js, dist/src/components/Typography/index.js, dist/src/components/UnitInput/index.js, dist/src/components/UniversalLink/index.js, dist/src/components/VerificationCode/index.js, dist/src/components/VolumeSize/index.js, dist/src/theme/deprecated/colors.js, dist/src/theme/tokens/dark.js, dist/src/theme/tokens/light.js, dist/src/utils/responsive/Breakpoint.js, dist/src/utils/responsive/utilities.js 189.5 KB (+0.04% 🔺)

@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #1642 (8a72367) into main (1c4a8da) will decrease coverage by 0.24%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   94.68%   94.44%   -0.25%     
==========================================
  Files         120      120              
  Lines        3328     3328              
  Branches      478      479       +1     
==========================================
- Hits         3151     3143       -8     
- Misses        128      133       +5     
- Partials       49       52       +3
Impacted Files Coverage Δ
src/components/Button/index.tsx 100.00% <ø> (ø)
src/components/LineChart/CustomLegend.tsx 100.00% <ø> (ø)
src/components/List/SelectBar.tsx 100.00% <ø> (ø)
src/components/List/index.tsx 93.85% <ø> (-5.27%) ⬇️
src/components/Menu/index.tsx 100.00% <ø> (ø)
src/components/Modal/index.tsx 97.29% <ø> (ø)
src/components/Pagination/index.tsx 100.00% <ø> (ø)
src/components/SwitchButton/index.tsx 100.00% <ø> (ø)
src/components/Typography/index.tsx 81.81% <20.00%> (+2.40%) ⬆️
src/components/Tooltip/index.tsx 93.15% <50.00%> (-2.63%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4a8da...8a72367. Read the comment docs.

@matthprost matthprost merged commit c4527c2 into main Jun 28, 2022
@matthprost matthprost deleted the feat/react-18 branch June 28, 2022 13:48
scaleway-bot pushed a commit that referenced this pull request Jun 28, 2022
@semantic-release-bot @scaleway-bot
chore(release): 0.164.0 [skip ci]
91967f2 
## [0.164.0](v0.163.6...v0.164.0) (2022-06-28)

### ⚙️ Features

* **deps:** update react monorepo to v18 (major) ([#1642](#1642)) ([c4527c2](c4527c2))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 0.164.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chambo-e added a commit that referenced this pull request Jun 29, 2022
@chambo-e
Revert "feat(deps): update react monorepo to v18 (major) (#1642)"
835e5eb 
This reverts commit c4527c2.
chambo-e added a commit that referenced this pull request Jun 29, 2022
@chambo-e
Revert "feat(deps): update react monorepo to v18 (major) (#1642)" (#1645
6997493 
)

This reverts commit c4527c2.
QuiiBz added a commit that referenced this pull request Aug 16, 2022
@QuiiBz
Revert "Revert "feat(deps): update react monorepo to v18 (major) (#1642…
1b50a5b 
…)" (#1645)"

This reverts commit 6997493.
QuiiBz added a commit that referenced this pull request Aug 16, 2022
@QuiiBz
Revert "Revert "feat(deps): update react monorepo to v18 (major) (#1642…
64cc363 
…)" (#1645)"

This reverts commit 6997493.
QuiiBz added a commit that referenced this pull request Aug 17, 2022
@QuiiBz
Revert "Revert "feat(deps): update react monorepo to v18 (major) (#1642…
39e236e 
…)" (#1645)"

This reverts commit 6997493.
QuiiBz added a commit that referenced this pull request Aug 17, 2022
@QuiiBz
feat: react 18 (#1775)
8cb0007 
* Revert "Revert "feat(deps): update react monorepo to v18 (major) (#1642)" (#1645)"

This reverts commit 6997493.

* fix: type errors

* chore: update lockfile

* chore(deps): revert emotion peer deps

* fix: update to latest jest-helpers

* chore: update loki snapshot

* fix: resolve review
scaleway-bot pushed a commit that referenced this pull request Aug 17, 2022
@semantic-release-bot @scaleway-bot
chore(release): 0.179.0 [skip ci]
a5cd885 
## [0.179.0](v0.178.3...v0.179.0) (2022-08-17)

### 📦 Chore

* **devdeps:** update dependency @scaleway/eslint-config-react to v3.5.1 ([#1774](#1774)) ([9cab428](9cab428))

### ⚙️ Features

* react 18 ([#1775](#1775)) ([8cb0007](8cb0007)), closes [#1642](#1642) [#1645](#1645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chambo-e chambo-e Awaiting requested review from chambo-e

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthprost @scaleway-bot