Remove all C requirements #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 14, 2015 07:40
- EVerything works - Still need to "import C" to get around Go bug 6751
|
Any chance of getting this merged? I am interested in using this library to read from the windows event log but I get panics from the casts in the C code on go 1.8. |
|
@krjackso I've made a fork that's up-to-date and has the DLL change here: https://github.com/alanctgardner/gowinlog Unfortunately I haven't got a Windows environment to test it right now. If you try it let me know if you see any bugs. |
|
@alanctgardner Thanks for setting that up, I've got a fork of your code that I'm now trying to test on. Should be able to get it working some time in the next day or two. There were a few compile issues on 386 but nothing insurmountable :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a rewrite that replaces all the cgo code with calls into DLLs, which are more idiomatic. In a perfect world we wouldn't even need mingw to build, but this issue requires cgo to be imported for the DLL callbacks to work.