Skip to content

Commit

Permalink
ARSN-379 adapt DelimiterNonCurrent/DelimiterOrphanDeleteMarker
Browse files Browse the repository at this point in the history
Adapt the two classes to a change in DelimiterVersions that was
required to comply with typescript and avoid a type mismatch with
`Delimiter.addContents()` which has a different signature: rename
`addContents()` to `addVersion()`.
  • Loading branch information
jonathan-gramain committed Dec 21, 2023
1 parent 211ea00 commit 9713f58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/algos/list/delimiterNonCurrent.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class DelimiterNonCurrent extends DelimiterVersions {
* @param {String} value - The value of the key
* @return {undefined}
*/
addContents(key, versionId, value) {
addVersion(key, versionId, value) {
this.nextKeyMarker = key;
this.nextVersionIdMarker = versionId;

Expand Down
2 changes: 1 addition & 1 deletion lib/algos/list/delimiterOrphanDeleteMarker.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class DelimiterOrphanDeleteMarker extends DelimiterVersions {
* @param {String} value - The value of the key
* @return {undefined}
*/
addContents(key, versionId, value) {
addVersion(key, versionId, value) {
// For a given key, the youngest version is kept in memory since it represents the current version.
if (key !== this.keyName) {
// If this.value is defined, it means that <this.keyName, this.value> pair is "allowed" to be an orphan.
Expand Down

0 comments on commit 9713f58

Please sign in to comment.