Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-390: Add scuba arn for policy #2212

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

BourgoisMickael
Copy link
Contributor

@BourgoisMickael BourgoisMickael commented Jan 26, 2024

Relates to SCUBA-76 and SCUBA-77
@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2024

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • maybe you'll want to release with a version bump

lib/policyEvaluator/utils/checkArnMatch.ts Outdated Show resolved Hide resolved
lib/policyEvaluator/RequestContext.ts Outdated Show resolved Hide resolved
lib/policyEvaluator/RequestContext.ts Outdated Show resolved Hide resolved
@BourgoisMickael BourgoisMickael force-pushed the improvement/ARSN-390-scuba-arn branch from 5383e93 to f265ed6 Compare February 5, 2024 13:07
@BourgoisMickael
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2024

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/improvement/ARSN-390-scuba-arn with contents from improvement/ARSN-390-scuba-arn
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/improvement/ARSN-390-scuba-arn origin/development/7.70
 $ git merge origin/improvement/ARSN-390-scuba-arn
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/improvement/ARSN-390-scuba-arn

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2024

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/improvement/ARSN-390-scuba-arn with contents from w/7.70/improvement/ARSN-390-scuba-arn
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/improvement/ARSN-390-scuba-arn origin/development/8.1
 $ git merge origin/w/7.70/improvement/ARSN-390-scuba-arn
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/improvement/ARSN-390-scuba-arn

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 5, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-390.

Goodbye bourgoismickael.

@bert-e bert-e merged commit f265ed6 into development/7.10 Feb 5, 2024
7 checks passed
@bert-e bert-e deleted the improvement/ARSN-390-scuba-arn branch February 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants