INTEGRATION [PR#2219 > development/8.1] ARSN-396: use request context aciton map for the bucket policies #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 Bucket Policies checks must support and evaluate the same actions as the ones sent to the IAM checks. Today, we only check a subset of it, so we missed the Versioned APIs.
…d' into tmp/octopus/w/7.70/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
…nbackend' into tmp/octopus/w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
williamlardier
force-pushed
the
w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
branch
from
5978c6b to
9c3586c
Compare
The new flags are set when IAM returns detailed information about the actions, whether they are allowed or denied, with the isImplicit flag. The mergePolicy must be updated to support the new fields, and do not merge policies that are for different actions. Note that this function will consider that any Allow takes precedence, so this behavior is not changed.
williamlardier
force-pushed
the
w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
branch
from
9c3586c to
851c72b
Compare
…gfix/ARSN-396-standardize-actionMapBP-and-chainbackend
…onMapBP-and-chainbackend' into w/7.70/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
ARSN-396-standardize-actionMapBP-and-chainbackend
…ze-actionMapBP-and-chainbackend' into w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
bert-e
deleted the
w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #2219.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackend $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/bugfix/ARSN-396-standardize-actionMapBP-and-chainbackendPlease always comment pull request #2219 instead of this one.