-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bf: ARSN-398 DelimiterMaster: fix when gap building is disabled #2223
bf: ARSN-398 DelimiterMaster: fix when gap building is disabled #2223
Conversation
Hello jonathan-gramain,My role is to assist you with the merge of this Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
5296fe8
to
8cac166
Compare
- Fix the situation where gap building is disabled by `_saveBuildingGap()` but we attempted to reset the building gap state anyway. - Introduce a new state 'Expired' that can be differentiated from 'Disabled': it makes `getGapBuildingValidityPeriodMs()` return 0 instead of 'null' to hint the listing backend that it should trigger a new listing.
8cac166
to
f63cb3c
Compare
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/bugfix/ARSN-398-doNotRefreshGapBuildingIfDisabled origin/development/8.1
$ git merge origin/bugfix/ARSN-398-doNotRefreshGapBuildingIfDisabled
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/bugfix/ARSN-398-doNotRefreshGapBuildingIfDisabled The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-398. Goodbye jonathan-gramain. |
Fix the situation where gap building is disabled by
_saveBuildingGap()
but we attempted to reset the building gap state anyway.Introduce a new state 'Expired' that can be differentiated from 'Disabled': it makes
getGapBuildingValidityPeriodMs()
return 0 instead of 'null' to hint the listing backend that it should trigger a new listing.