Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-400: Add scuba admin actions #2224

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

BourgoisMickael
Copy link
Contributor

For admin access, a policy like that should be set:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "scuba:AdminStartIngest",
                "scuba:AdminStopIngest",
                "scuba:AdminReadRaftCseq",
                "scuba:AdminTriggerRepair"
            ],
            "Resource": [
                "arn:scality:scuba:::admin"
            ]
        }
    ]
}

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm surprised to see scuba code in 7.10 branch, was it intended? Regarding this particular PR since it's a bugfix I think it's fine that it goes to 7.10 though.

@BourgoisMickael
Copy link
Contributor Author

Maybe it will not be used by 7.10 branches, I'm not sure

@BourgoisMickael
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2024

Incorrect fix version

The Fix Version/s in issue ARSN-400 contains:

  • 7.10.59

  • 7.70.26

  • 8.1.124

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.60

  • 7.70.27

  • 8.1.125

Please check the Fix Version/s of ARSN-400, or the target
branch of this pull request.

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2024

Incorrect fix version

The Fix Version/s in issue ARSN-400 contains:

  • 7.10.59

  • 7.70.26

  • 8.1.124

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.60

  • 7.70.27

  • 8.1.125

Please check the Fix Version/s of ARSN-400, or the target
branch of this pull request.

The following options are set: approve, create_integration_branches

@BourgoisMickael
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-400.

Goodbye bourgoismickael.

@bert-e bert-e merged commit 9bf1bcc into development/7.10 Feb 26, 2024
5 checks passed
@bert-e bert-e deleted the improvement/ARSN-400-scuba-admin branch February 26, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants