-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bucket quota should be treated and stored as BigInts #2279
Merged
+1,602
−633
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c50375c
Configure project to accept latest BigInt-related notation
williamlardier 16df786
Switch quotas to BigInt
williamlardier 4cfff62
Fix ubuntu runner os version to 22
williamlardier 03b0373
Support SOSAPI metrics as large numbers
williamlardier 749bc00
Consistent types for Auth APIs
williamlardier 3bed608
Be lenient on the input BucketInfo type for bucket quota
williamlardier f6eb2c4
Accept bigint and numbers for the veeamsosapi capability
williamlardier 11dee85
Do not use the toJSON
williamlardier bfe913d
Migrate MongoClientInterface to typescript
williamlardier 57d5fb2
Fix BucketInfo class
williamlardier 5dfa9ae
Improve types and linting
williamlardier 4302856
Improve typescript migration
williamlardier cf25b66
Update code post review
williamlardier 02ab640
Be more safe against undefined quota or capabilities fields
williamlardier 14b341d
Bump project version
williamlardier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
{ | ||
"extends": "scality", | ||
"env": { | ||
"es2020": true | ||
}, | ||
"parserOptions": { | ||
"ecmaVersion": 2020 | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is related to the fact that in MongoClientInterface we actually pass an array here: the function type was not properly defined here, leading to TS error. Having an array here is fine and expected.