Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Storybook to v8 #787

Merged

Conversation

JeanMarcMilletScality
Copy link
Contributor

@JeanMarcMilletScality JeanMarcMilletScality commented Oct 31, 2024

Upgrade Storybook to v8:

Migration to Storybook V8 and update 'tests' workflow

Storybook Migration:

  • Added new Storybook addons and SWC compiler configuration in .storybook/main.ts. [1] [2]
  • Removed ScrollbarWrapper import and added tags parameter in .storybook/preview.js. [1] [2]
  • Rename spacing.stories.mdx to spacing.mdx (Stroybook recognizes .stories.mdx as an old way to declare stories and block it)

GitHub Actions Workflow Updates:

  • Updated the branch patterns in .github/workflows/tests.yaml to use single quotes for consistency.
  • Updated the actions/checkout and actions/setup-node versions to v4 and changed the Node.js version to 20.

Code Improvements:

  • Removed outdated TypeScript error comments in src/lib/components/tabsv2/Tabsv2.component.tsx and src/lib/organisms/attachments/AttachmentTable.tsx. [1] [2]

…e spacing.stories.mdx to spacing.mdx as it is not supported by storybook (it refers to an old way to build stories even if file does not use it this way)
@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2024

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality changed the title upgrade storybook to v8, add config for swc to work with React, renam… upgrade Storybook to v8 Oct 31, 2024
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue ARTESCA-13637.

Goodbye jeanmarcmilletscality.

The following options are set: approve

@bert-e bert-e merged commit aa40621 into development/1.0 Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants