Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Kubernetes to 1.16.2 #2063

Merged
merged 7 commits into from
Nov 22, 2019
Merged

Upgrade Kubernetes to 1.16.2 #2063

merged 7 commits into from
Nov 22, 2019

Conversation

gdemonet
Copy link
Contributor

Component: kubernetes

Context: New development/2.5 branch

Summary:

  • Some deprecated APIs were removed in K8s 1.16, so we need to update some objects and remove the support for those in our Salt modules
  • Downgrade is disabled for this branch, due to an issue in the ordering (trying to deploy K8s objects for the destination version while k-a is not downgraded yet, hence conflicting on those deprecated APIs)

gdemonet and others added 7 commits November 21, 2019 23:17
@gdemonet
Bump Kubernetes version to 1.16.2
bee1252 
For the creation of the development/2.5 branch
@gdemonet
Bump etcd version to 3.3.15-0 for K8s 1.16.2
1bdfb66 
The default etcd version was increased in upstream Kubernetes, see
https://github.com/kubernetes/kubernetes/blob/v1.16.2/cmd/kubeadm/app/constants/constants.go#L421-L429
for more details.
@gdemonet
salt: Remove use of old APIs
f2a5c33 
Since K8s 1.16 stops serving some APIs under extensions/v1beta1,
we update all occurences that were still using these deprecated
APIs.
@TeddyAndrieux @gdemonet
salt: Remove support of old APIs
1fc58e4 
Since K8s 1.16 stops serving some APIs under extensions/v1beta1, we
remove the support for them in our `kubernetes_utils` module.
@TeddyAndrieux @gdemonet
eve: Make create-volume option configurable
c205e46 
Add environment variable to configure which branch to checkout before
running `eve/create-volumes.sh` script and put `PRODUCT_TXT` and
`PRODUCT_MOUNT` environment variable in `env` section to be able to
override it in `eve/main.yml`
@TeddyAndrieux @gdemonet
eve: Provision volumes after install of previous version
38bc0a7 
Since dev2.4 we need to provision volumes to have working prometheus
stack, so in upgrade context we need to first provision volumes before
running fast tests
@TeddyAndrieux @gdemonet
eve/downgrade: Deactivate downgrade in CI tests
c5ef29b 
Currently downgrade does not work because we downgrade all Kubernetes
objects before downgrading the API server of the bootstrap node.
Kubernetes 1.16 removed the support of some APIs that we use in the 2.4
branch, hence we cannot downgrade without re-ordering the whole process.

See: #2058
@gdemonet gdemonet added moonshot kind:dependencies Pull requests that update a dependency file labels Nov 21, 2019
@gdemonet gdemonet added this to the MetalK8s 2.5.0 milestone Nov 21, 2019
@gdemonet gdemonet requested a review from a team November 21, 2019 22:35
@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2019

Hello gdemonet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

This was referenced Nov 21, 2019
Merged
Merged
Merged
@bertranddemiddelaer
Copy link

/bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2019

Queue out of order

The changeset has received all authorizations to enter the merge queue,
however the merge queue is currently in an incoherent state. In order
to protect this pull-request, I have have not added the changeset to the
queue.

Please contact a member of release engineering.

The following options are set: bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2019

Status

Status report is not available.

The following options are set: bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2019

Queue out of order

The changeset has received all authorizations to enter the merge queue,
however the merge queue is currently in an incoherent state. In order
to protect this pull-request, I have have not added the changeset to the
queue.

Please contact a member of release engineering.

The following options are set: bypass_author_approval

@TeddyAndrieux
Copy link
Collaborator

/status

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.5

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.5

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

Please check the status of the associated issue None.

Goodbye gdemonet.

@bert-e bert-e merged commit c5ef29b into development/2.5 Nov 22, 2019
@bert-e bert-e deleted the feature/upgrade-to-kubernetes-1.16 branch November 22, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
kind:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
MetalK8s 2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gdemonet @bert-e @bertranddemiddelaer @TeddyAndrieux