Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Pin python protobuf version and change salt repo URL #3781

Merged
merged 2 commits into from
May 30, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

Fix the build of salt-master and metalk8s-utils images

  • etcd3 python lib require protobuf>=3.6.1 python lib and the latest protobuf version is not compatible with python3.6
# pip3 install etcd3
Collecting etcd3
  Using cached etcd3-0.12.0.tar.gz (63 kB)
Collecting grpcio>=1.27.1
  Downloading grpcio-1.46.3-cp36-cp36m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (4.4 MB)
     |████████████████████████████████| 4.4 MB 14.0 MB/s 
Collecting protobuf>=3.6.1
  Downloading protobuf-4.21.0-py2.py3-none-any.whl (164 kB)
     |████████████████████████████████| 164 kB 65.9 MB/s 
ERROR: Package 'protobuf' requires a different Python: 3.6.8 not in '>=3.7'
  • Salt master repo URL moved and yum does not handle redirect
failure: repodata/repomd.xml from saltstack-repo: [Errno 256] No more mirrors to try.
https://repo.saltstack.com/py3/redhat/7/x86_64/archive/3002.8/repodata/repomd.xml: [Errno 14] HTTPS Error 301 - Moved Permanently

The latests python protobuf versions are not compatible with python3.6,
since `etcd3` require protobuf and do not check for protobuf version
let's just install protobuf manually
The saltstack repository moved from `repo.saltstack.com` to
`repo.saltproject.io` the old URL honor a permanent moved with 301 but
yum does not follow those redirect
@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner May 30, 2022 09:27
@bert-e
Copy link
Contributor

bert-e commented May 30, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 30, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented May 30, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 30, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 30, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 48b0ddc into development/2.11 May 30, 2022
@bert-e bert-e deleted the bugfix/fix-salt-master-build branch May 30, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants