Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures this addon calls _super in included #1

Closed
wants to merge 1 commit into from

Conversation

scalvert
Copy link
Owner

Ember. 3.0.0 removed the use of Ember.WeakMap in favor of native WeakMap. As part of our application's migration to 3.0.0, we found an issue when using that version in conjunction with this addon's use of ember-weakmap.

Specifically, because this addon implements an included hook but does not call _super in that hook, child addons that also implement an included hook don't have their hook invoked.

This is reproducible using the following steps:

  1. create a new ember app with the latest version of ember cli - ember new foo --yarn
  2. add ember-truncate - yarn add [email protected]
  3. run tests - ember t

@scalvert scalvert closed this Aug 24, 2018
@scalvert scalvert deleted the included-calls-super branch September 8, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant