Ensures this addon calls _super
in included
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember. 3.0.0 removed the use of
Ember.WeakMap
in favor of nativeWeakMap
. As part of our application's migration to 3.0.0, we found an issue when using that version in conjunction with this addon's use ofember-weakmap
.Specifically, because this addon implements an
included
hook but does not call_super
in that hook, child addons that also implement anincluded
hook don't have their hook invoked.This is reproducible using the following steps:
ember new foo --yarn
yarn add [email protected]
ember t