-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Html template #157
New Html template #157
Conversation
@djalmaaraujo your pull request is missing a changelog! |
2765db5
to
aa93f5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 92.37% 92.42% +0.04%
==========================================
Files 12 12
Lines 459 462 +3
==========================================
+ Hits 424 427 +3
Misses 35 35
Continue to review full report at Codecov.
|
f5e683f
to
e585db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
Something that comes to my mind now is that if these green/yellow/red colors may give the impression of success/failure for each of the requests being executed.
Good point. We will bring tests results to this report soon. So we will display in a clear way if the test pass or failed. Maybe a big But I believe, then, we will not have this confusion. What do you think? |
Also, you can check an example of the generated report here: https://github.com/scanapi/scanapi-examples/blob/master/scanapi-demo/scanapi-report.html |
Yeah, that's something to think about. Especially if we plan to bring test results to the same report. Red to me looks like something errored. |
I can create a new "ADR" to discuss about the tests results in the reports (both html and md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
New HTML template using jinja. 🥳
The reason the CSS is inline is because we want to avoid adding useless dependencies to the project.
Closes #61 #57