Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] TWITTER_BUTTON_ACTIVE environment variable not working with 1.11.1 #388

Closed
pquantin opened this issue Feb 23, 2025 · 1 comment · Fixed by #389
Closed

[Bug] TWITTER_BUTTON_ACTIVE environment variable not working with 1.11.1 #388

pquantin opened this issue Feb 23, 2025 · 1 comment · Fixed by #389
Labels
bug Something isn't working

Comments

@pquantin
Copy link

Describe the bug
I just noticed that the TWITTER_BUTTON_ACTIVE=false environment variable no longer hides the X icon in the about screen. Maybe related to 02c95dd?

To Reproduce
Steps to reproduce the behavior:

  1. Set TWITTER_BUTTON_ACTIVE=false in the docker compose yaml file
  2. Start the container
  3. Go to about page
  4. The X icon is visible

Expected behavior
The X icon should be hidden

Bug occurs on self-hosted PairDrop instance
Yes

Self-Hosted Setup
Proxy: Nginx
Deployment: docker compose
Version: v1.11.1
@pquantin pquantin added the bug Something isn't working label Feb 23, 2025
schlagmichdoch added a commit that referenced this issue Feb 23, 2025
@schlagmichdoch
FIX: switch off twitter button via env var not possible (#388)
b0b091c
@schlagmichdoch schlagmichdoch mentioned this issue Feb 23, 2025
Merged
@schlagmichdoch
Copy link
Owner

You're right. Sorry for the mishap!

Will be fixed via #389 in next version

schlagmichdoch added a commit that referenced this issue Feb 24, 2025
@schlagmichdoch
Increase version to v1.11.2
4862ba3 
## Enhancements
- Speed up update process by skipping waiting and claiming currently open pages -> no need to close all tabs in order to get an update anymore
- Update Bluesky icon from square to butterfly
- Update node dependencies

## Fixes
- Prevent service-worker from responding with redirect (fixes #384)
- Fix: switch off twitter button via env var not possible (#388)
- Add missing files to paths that get cached upon sw installation

## Languages
- Translations updates from Hosted Weblate (Japanese)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix buttons on about page schlagmichdoch/PairDrop
2 participants
@pquantin @schlagmichdoch