Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding doctest-remote-data-all directive #281

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 24, 2025

This should address #146

EDIT: Fix #146

@bsipocz bsipocz added this to the v1.4.0 milestone Jan 24, 2025
@bsipocz

This comment was marked as outdated.

@bsipocz bsipocz marked this pull request as draft January 24, 2025 02:02
@bsipocz
Copy link
Member Author

bsipocz commented Jan 24, 2025

Never mind the error above, the tests somehow picked up an outdated version instead of the one I was actively working on. So if CI is all green here, it should be good to go as it works as expected with e.g. astroquery.

@bsipocz bsipocz marked this pull request as ready for review January 24, 2025 06:33
@bsipocz bsipocz requested a review from pllim January 24, 2025 06:33
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit 5e1a479 into scientific-python:main Jan 24, 2025
19 checks passed
@bsipocz bsipocz deleted the doctest-remote-data-all branch January 24, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add another remote-data directive, that works for the whole file/rest of the file
2 participants