feat: Simplify API expecting only one input file

Remove obsolete ARGS argument that is being ignored and here only for backward compatibility. Switch from DEPENDS to MAIN_DEPENDENCY to suggest Visual Studio where to hang the custom command. Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
scikit-build · Jul 17, 2024 · cd86550 · cd86550
1 parent 8b256d5
commit cd86550
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/cython_cmake/cmake/UseCython.cmake b/src/cython_cmake/cmake/UseCython.cmake
@@ -7,7 +7,7 @@
 # Create custom rules to generate the source code for a Python extension module
 # using cython.
 #
-#   Cython_compile_pyx(<pyx_file1> [<pyx_file2> ...]
+#   Cython_compile_pyx(<pyx_file>
 #                     [LANGUAGE C | CXX]
 #                     [CYTHON_ARGS <args> ...]
 #                     [OUTPUT_VARIABLE <OutputVariable>])
@@ -77,8 +77,12 @@ function(Cython_compile_pyx)
     ${ARGN}
     )
 
-  # Get source file location
+  # Get input
   set(_source_files ${_args_UNPARSED_ARGUMENTS})
+  list(LENGTH _source_files input_length)
+  if(NOT input_length EQUAL 1)
+    message(FATAL_ERROR "One and only one input file must be specified, got '${_source_files}'")
+  endif()
 
   # Set target language
   get_property(_languages GLOBAL PROPERTY ENABLED_LANGUAGES)
@@ -126,13 +130,12 @@ function(Cython_compile_pyx)
     add_custom_command(
       OUTPUT ${generated_file}
       COMMAND ${CYTHON_EXECUTABLE}
-      ARGS
         ${_language_arg}
         ${_args_CYTHON_ARGS}
         ${_depfile_arg}
         ${pyx_location}
         --output-file ${generated_file}
-      DEPENDS
+      MAIN_DEPENDENCY
         ${_source_file}
       DEPFILE
         ${_cython_depfile}