fix: bump to manylinux 2010, add test #158
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #157. I've uploaded manually built 1.11.1 binaries for manylinux2010. This adds a test that shows the breakage, then adds the bump to 2010 which fixes it. Should we also ship manylinux1? I'd say no (in fact, I think I'd be fine to delete the old manylinux1 binaries for 1.11.1) - it's probably more likely that and old pip would get a broken binary than someone would need this on actual manylinux1.
I'd like to know why this broke - was is ninja, or is there some issue with the latest manylinux1? Maybe someone will investigate someday.
FYI, to build locally with a different manylinux, say for the 32-bit wheel: