Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use same convert_to_generic_platform_wheel.py script as cmake #49

Merged
merged 2 commits into from
Jul 4, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 29, 2021

This prepares for universal2 wheels and allows to create py2.py3 wheels

@mayeut mayeut mentioned this pull request May 29, 2021
@henryiii
Copy link
Contributor

henryiii commented Jun 2, 2021

Why isn't there something more official for doing this sort of thing? There are other packages that have "special" output tag requirements. I've seen a regex package that needed python version only (no plat/arch), we had multiple tags in cibuildwheel as a macOS hack for a little bit, etc.

@jcfr
Copy link
Contributor

jcfr commented Jun 2, 2021

Why isn't there something more official for doing this sort of thing? There are other packages that have "special" output tag requirements. I've seen a regex package that needed python version only (no plat/arch), we had multiple tags in cibuildwheel as a macOS hack for a little bit, etc.

A while back I looked into this and then work on transferring the wheeltools project into the scikit-build organization.

See scikit-build/wheeltools#2

That said, I am wondering if there is a more current effort and if we should archive or abandon wheeltools .... I didn't have a chance to look at the details since then.

This prepares for `universal2` wheels and allows to create `py2.py3` wheels
@henryiii
Copy link
Contributor

henryiii commented Jul 4, 2021

I think this is now "passing" - Travis is out of credits and AppVeyor is being weird, but CircleCI is passing.

@henryiii henryiii closed this Jul 4, 2021
@henryiii henryiii reopened this Jul 4, 2021
@henryiii
Copy link
Contributor

henryiii commented Jul 4, 2021

Going to give AppVeyor another chance, turned off the Travis requirement.

@mayeut mayeut merged commit 8e5578e into scikit-build:master Jul 4, 2021
@mayeut mayeut deleted the convert-wheel branch July 4, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants