-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CuDF backend doesn't check CuDF version before doing version-dependent things #3335
Comments
It seems that when I said "they kept the same arguments but forced you to supply and name them", I was wrong :| |
Okay, then 24.10.00 is the first release that we support. This issue stands as a add that version check, in a style similar to the Numba version check. |
Here is the other PR in cudf specifically for the signature change of NumericalColumn (i.e., the argument names): rapidsai/cudf#16457 (August 15). Before that PR is when our current code would actually break. |
* version check in to_cudf for API change fixes #3335 * style: pre-commit fixes * Fix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ianna Osborne <[email protected]> Co-authored-by: Peter Fackeldey <[email protected]>
I had cudf 24.04.01 installed (apparently, when a package comes from another channel,
update --all
doesn't get it), and got this error fromtests-cuda/test_3051_to_cuda.py
:Naturally, this is #3309. I updated cudf to 24.10.01 and there's no problem.
If you try to use this feature without CuDF, I'm sure you'd get some error message saying, "you need to install CuDF," but the above error message is mysterious if you don't know that you have an old version of CuDF. It would be more helpful if it said, "you need to install VERSION XYZ of CuDF," like
awkward/src/awkward/numba/__init__.py
Lines 34 to 38 in 8f69dbf
@martindurant, is 24.10.00 the exact minimum? Which is the minimum CuDF version that is okay/the maximum CuDF version that is bad?
The text was updated successfully, but these errors were encountered: