Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing ListArray is the quickest way to understanding if the getitem design is right. #11

Merged
merged 35 commits into from
Sep 26, 2019
Merged

Implementing ListArray is the quickest way to understanding if the getitem design is right. #11

merged 35 commits into from
Sep 26, 2019
+2,872 −1,236

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski
Start by refreshing RawArray class.
70ff231
@jpivarski
Reinstate the RawArray tests.
190266e
@jpivarski
RawArray now has the infrastructure for getitem.
6abc734
@jpivarski
Maybe I shouldn't be working on RawArray; I don't see how this will f…
69bfbaa 
…it into ListOffsetArray.
@jpivarski
Work on ListArray instead.
a6fe790
@jpivarski
Cleaned up setid.
245fbb4
@jpivarski
Ready to work on ListArray.
876a1f0
@jpivarski
More cleaning up; working on making getitem universal.
b5a5e16
@jpivarski
Cleaned up a lot of duplication in pyawkward.cpp.
8f6d5dc
@jpivarski
Rename Content::get (and others) to ::getitem_at and ::slice to ::get…
9de7efc 
…item_range.
@jpivarski
Start on ListArray tests.
e86d7cb
@jpivarski
Tested ListArray::getitem_at and ListArray::getitem_range.
d62f63d
@jpivarski
Ready to work on ListArray::getitem_next.
4e390c2
@jpivarski
Implemented basic (not entirely correct) ListArray::getitem for Slice…
1cb8682 
…Array.
@jpivarski
more correct
b3b1365
@jpivarski
Very nearly have recursive ListArray::getitem((array, array)).
aeac16f
@jpivarski
it works
8d4562d
@jpivarski
Split ListArray::getitem(array) into advanced and non-advanced cases.
8ecdbed
@jpivarski
[skip ci] calling NumpyArray::getitem_next from getitem_next isn't lo…
8f1d9e3 
…oking promising
@jpivarski
It looks like NumpyArray::getitem_next(3 args) can be a simple call t…
736582b 
…o NumpyArray::getitem_next(6 args)
@jpivarski
ListArray::getitem_next slice and array tests work; need to clean up.
2650a07
@jpivarski
Cleaned up.
93ec0c4
@jpivarski
Solved ListArray::getitem_next(SliceAt).
5231e11
@jpivarski
Cleaned up ListArray::getitem_next(SliceAt).
e3d4345
@jpivarski
ListArray::getitem_next(SliceEllipsis), but SliceNewAxis will have to…
96b9ce3 
… wait for RegularArray.
@jpivarski
ListOffsetArray can do everything ListArray can do.
abe9c55
@jpivarski
Started converting cases that create ListArrays into creating ListOff…
bfbc460 
…setArrays.
@jpivarski
Continuing to convert cases that create ListArrays into creating List…
b9a678c 
…OffsetArrays.
@jpivarski
ListArray and ListOffsetArray now share an entry getitem_next.
241c620
@jpivarski
Fix problems in compilation.
9fb597b
@jpivarski jpivarski changed the title [WIP] Implementing ListArray is the quickest way to understanding if the getitem design is right. Implementing ListArray is the quickest way to understanding if the getitem design is right. Sep 26, 2019
@jpivarski jpivarski merged commit fe17e09 into master Sep 26, 2019
@jpivarski jpivarski deleted the feature/listarray-getitem branch September 26, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpivarski