Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues and anything that looks in need of cleanup. #110

Merged
merged 23 commits into from
Feb 6, 2020
Merged

Fix several issues and anything that looks in need of cleanup. #110

merged 23 commits into from
Feb 6, 2020

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Feb 4, 2020 •
edited
Loading

@jpivarski
[WIP] Fix several issues and anything that looks in need of cleanup.
cf2b48e
@jpivarski
Fixed #109.
795ff7b
@jpivarski
Fixed #109 better.
7a06cac
@jpivarski
[skip ci] Don't forget the dependence on 'at'.
dede333
@jpivarski
Rename argument in NumpyArray-from-Index* constructors.
007e561
@jpivarski
Not-fix #108 (isna doesn't actually have UnionArray output).
34b7c82
@jpivarski
STARTING on #101: replace '__class__' with either '__record__' or '__…
5170647 
…array__'.
@jpivarski
[skip ci] Rename awkward1.behavior -> awkward1.behaviors.
1d647e0
@jpivarski
Rename and consolidate awkward1.classes,functions -> awkward1.behavior.
d8553b5
@jpivarski
We can distinguish between arrays and records.
1fd199b
@jpivarski
Fix test.
a827d8a
@jpivarski
Fixed tests again.
ce7ae9c
@jpivarski
Implementing deep matching when applying behavioral classes.
58f32c0
@jpivarski
Don't override an explicitly assigned class.
08e8afb
@jpivarski
Fix Python 2.7.
f95abda
@jpivarski
Stubs for *::equal(other, axis) operation.
e5b20ac
@jpivarski
Stubs for *::equal_part(other, axis, depth) operation.
36283cd
@jpivarski
Maybe array_equal shouldn't be in C++. Anyway, add UnionArray and Ind…
9ce74ae 
…exedArray 'simplify' in broadcast_and_apply.
@jpivarski
I don't know...
64c1055
@jpivarski
Save work for now...
10ed8f6
@jpivarski
Have solution; cleaned up scratchwork, need to fully test it.
eb51c49
@jpivarski
String equality checking completely works. I'm going to remove 'array…
0ab2c57 
…_equal' from this PR.
This was referenced Feb 6, 2020
Closed
Closed
@jpivarski jpivarski changed the title [WIP] Fix several issues and anything that looks in need of cleanup. Fix several issues and anything that looks in need of cleanup. Feb 6, 2020
@jpivarski jpivarski merged commit 2f376e3 into master Feb 6, 2020
@jpivarski jpivarski deleted the feature/PR110-various-cleanup branch February 6, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpivarski