Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Numba StructModels with CPointers and check all reference counts. #118

Merged
merged 86 commits into from
Feb 25, 2020
Merged

Replace Numba StructModels with CPointers and check all reference counts. #118

merged 86 commits into from
Feb 25, 2020

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski linked an issue Feb 16, 2020 that may be closed by this pull request
Migrate Numba models to have CPointers to fields #95
Closed
@jpivarski
Copy link
Member Author

Slow laptop with all tests in:

real    0m50.159s
user    0m49.790s
sys     0m0.679s

Same laptop with Numba tests removed (16 out of 261):

real    0m4.444s
user    0m4.238s
sys     0m0.564s

:)

@jpivarski
Moved Numba so that it can be rewritten via side-by-side windows.
85e276d
@jpivarski
[skip ci] Switch to big computer.
7b16c0f
@jpivarski
[skip ci] Numba entry_points have been successfully tested.
16713e2
@jpivarski
Rename all the tests to get another order of magnitude of breathing r…
e72a6bd 
…oom.
@jpivarski
We have a way of testing nrt.refcounts.
8d8f37a
@jpivarski
Complete lowered NumpyArray implementation to work with.
39e183d
@jpivarski
ContentSliceType as a general feature.
58786b2
@jpivarski
Suprise: create_struct_proxy with value != None ALLOCATES A NEW OBJEC…
4f73fff 
…T. Use context.make_helper
@jpivarski
[skip ci] Last checkin before changing tactics.
9bd70bb
@jpivarski
Testing code for pointers.
4654b47
@jpivarski
Not a complete test yet, but soon.
d30fa01
@jpivarski
This is a complete test.
10c9475
@jpivarski
[skip ci] Working on the lookup table idea.
6bf3838
@jpivarski
[skip ci] The model seems to be working well.
779f9f5
@jpivarski
Can fully transform into and out of a lookup/view/type.
44d2847
@jpivarski
Fewer files.
30b18d1
@jpivarski
Switch to laptop.
445f34d
@jpivarski
Fixed a bug.
13011d7
@jpivarski
Successfully unboxing and boxing.
d465f91
@jpivarski
Reference counts are properly accounted for.
179442a
@jpivarski
Implemented len.
b4c6ea8
@jpivarski
[skip ci] getting close to NumpyArray::lower_getitem_at.
ba5e062
@jpivarski
[skip ci] stop for a moment.
990cd2c
@jpivarski
Custom methods work.
155f166
@jpivarski
Operator overloading works, too.
c8897d4
@jpivarski
Fix 32-bit bug.
4513b37
@jpivarski
Python 2 friendly.
e5743b6
@jpivarski
Remove 'fill' from FillableArray.
995c81a
@jpivarski
Removed old Numba tests. (New ones reproduce everything except identi…
50ecdd9 
…ties and type-handling, which weren't implemented in the revision.)
@jpivarski
Added 'append' stubs to Fillables.
9b7134c
@jpivarski
Added 'IndexedFillable' stubs.
9512b49
@jpivarski
Connect 'append' (and now 'extend') to Python.
a1538eb
@jpivarski
Basic 'append' (and 'extend') is working.
0da2338
@jpivarski
IndexedFillable works with UnionFillable.
5165a23
@jpivarski
FillableArray::append, extend is done.
cb9e7c3
@jpivarski
Pass through sharedptrs.
6aeb652
@jpivarski
First lowered 'append' case works.
d6c69dd
@jpivarski
Start specializing IndexedFillable to different Content types and fix…
739ff94 
… 32-bit bug.
@jpivarski
Record no longer holds a copy of RecordArray, but a reference to it. …
266b929 
…(Remember, RecordArray is immutable because ak.Array.__setitem__ replaces its _layout, rather than changing it in-place.)
@jpivarski
Repeatedly filling with IndexedFillables doesn't make a deep stack of…
c6c57a7 
… IndexedArrays.
@jpivarski
UnionFillable covers all IndexedFillable cases.
330bf78
@jpivarski
Lowered FillableArray::extend works.
3d952dd
@jpivarski jpivarski changed the title [WIP] Replace Numba StructModels with CPointers and check all reference counts. Replace Numba StructModels with CPointers and check all reference counts. Feb 25, 2020
@jpivarski
Copy link
Member Author

This PR eliminated 24,000 lines of code. :)

@jpivarski
Copy link
Member Author

Nope, forgot about the moved directory; now this PR has eliminated 28,000 lines of code.

@jpivarski jpivarski merged commit 6c70299 into master Feb 25, 2020
@jpivarski jpivarski deleted the feature/PR118-numba-cpointers branch February 25, 2020 21:50
@jpivarski jpivarski mentioned this pull request Mar 11, 2020
Merged
3 tasks
@jpivarski jpivarski mentioned this pull request Apr 11, 2020
Closed
@jpivarski jpivarski mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Numba models to have CPointers to fields
1 participant
@jpivarski