-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use nplike.asarray
#2134
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (For posterity: we talked about this in our weekly Zoom meeting. The functionality of asarray
and array
is being combined in Array-API, so we're following the same pattern in our nplikes for future-proofing.)
The work to move to an array-API inspired UX requires that we drop
array
andasarray
distinctions; nowasarray
takes acopy
parameter, and drops theorder
parameter.I'm gradually dropping
nplike
usage in our tests, where appropriate; we should probably focus on testing L1 and L2, not L3.