ci: test NumPy < 1.17 #2142
Merged
ci: test NumPy < 1.17 #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Jan 19, 2023
|
@jpivarski I think this can be merged now, no? It tests our current lower bound, and we can raise it to 1.17 when we make our next minor release. |
|
Oh, I was reading it backward! Yes, we should be testing our current minimum bound. This PR can be merged now (and its inverse has to wait until 2.1.0). |
douglasdavis
pushed a commit
to douglasdavis/awkward
that referenced
this pull request
Jan 19, 2023
* ci: test NumPy < 1.17 * chore: drop old file * ci: use 1.14.5 explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recollection of this test special case is that we want to ensure our oldest NumPy supported version is building & testing properly. I've set this to 1.14.5 for now, which is what
oldest-supported-numpyreports for 3.7. This CI configuration was seemingly backwards.