fix: specify dtype for buffers in from_rdataframe.
#2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 999aaab.
agoose77
requested review from
ioanaif and
ianna
and removed request for
ioanaif
|
Sorry for the review ping Ioana 🤦; muscle memory as you've reviewed a couple of my PRs recently! |
Codecov Report
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that we're over-allocating here, because the default dtype is usually a 64-bit float on most systems. In any case, it's larger than a single byte, whilst I believe that we want to be allocating exactly
item.secondbytes.@ianna are you able to check this logic for me? :)