Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type_to_name for Layout builder cxx_14 target #2165

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jan 26, 2023

  • temporary replacement helper variable templates for these that are part of C++17
  • char specialisation of type_to_name needed for Layout builder to generate a correct form

@ianna ianna requested a review from jpivarski January 26, 2023 10:19
@ianna ianna changed the title fix: cpp tests fix: update type_to_name for Layout builder cxx_14 target Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #2165 (d5076b3) into main (37547b0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@ianna ianna temporarily deployed to docs-preview January 26, 2023 10:34 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this. Our current standard is C++14, so if std::is_xyz_v<T> is a C++17 thing, then we should define our own.

(Our C++ standard is constrained by the Docker images that pip uses to build wheels for many-Linux targets: they're tied to particular versions of gcc. I don't want to get into adding "download a new gcc" as a step in the wheel-building procedure; dependence on external downloads makes a build procedure more brittle.)

header-only/awkward/utils.h Outdated Show resolved Hide resolved
@ianna ianna temporarily deployed to docs-preview January 26, 2023 14:53 — with GitHub Actions Inactive
@ianna ianna merged commit da5cab0 into main Jan 27, 2023
@ianna ianna deleted the ianna/fix-cpp-tests-for-cxx_14 branch January 27, 2023 07:01
ianna added a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants