fix: support mask_identity=True for axis=None in ptp, std, etc.
#2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
mask_identity=True for axis=None reductionmask_identity=True for axis=None in ptp, std, etc.
|
Linting will be fixed by #2153 or by upgrading |
agoose77
force-pushed
the
agoose77/fix-reducer-axis-none
branch
from
438117b to
b065831
Compare
jpivarski
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2020, these tests were
xfailed. I must have done so whilst working locally, and committed the change.This PR restores support for
mask_identity=Truefor theaxis=Nonecase of these composite reductions by pulling out the result as the final operation. As such, we choose what the identity value is for these reductions (np.nan, except forptpwhich returns0)