fix: preserve dimensions for keepdims=True, axis=None reductions
#2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Jan 30, 2023
Comment on lines
+802
to
+808
| if not check_regular and ( | ||
| left.is_list and right.is_regular or left.is_regular and right.is_list | ||
| ): | ||
| left = left.to_ListOffsetArray64() | ||
| right = right.to_ListOffsetArray64() | ||
| else: | ||
| return False |
There was a problem hiding this comment.
We don't use this here, but I wrote it, and then removed the usage. I think it's good to keep for future tests.
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Jan 30, 2023
agoose77
changed the title
keepdims=True, axis=None reductions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2159 by adding a new
keepdimsto the renamedak._do.remove_structurefunction. This just moves the list boundaries to the start and end elements of each list, so that the final result is a nested series of length-1 lists (besides the innermost dimension of lengthN).