Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump NumPy version #2282

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Mar 4, 2023

This PR bumps the minimum NumPy version to 1.17.0, in line with #2143

@jpivarski can you remind me why we settled on 1.17 instead of aligning with NEP 29? I know we made this decision, but can't recall why.

@agoose77 agoose77 mentioned this pull request Mar 4, 2023
5 tasks
@agoose77 agoose77 requested a review from jpivarski March 4, 2023 20:54
@agoose77 agoose77 temporarily deployed to docs-preview March 4, 2023 21:09 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #2282 (d6cf48d) into main (bb4279f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@agoose77 agoose77 temporarily deployed to docs-preview March 5, 2023 17:17 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remind me why we settled on 1.17 instead of aligning with NEP 29?

I didn't recognize that NEP 29 is a community-wide recommendation, rather than something NumPy is doing and other projects ad-hoc chose to emulate it. But I went back and read it and indeed:

This is an unusual NEP in that it offers recommendations for community-wide policy and not for changes to NumPy itself. Since a common place for SPEEPs (Scientific Python Ecosystem Enhancement Proposals) does not exist and given NumPy’s central role in the ecosystem, a NEP provides a visible place to document the proposed policy.

This is anticipating the development of SPECs, particularly SPEC 0.

For Awkward 2.1, we should continue with what we said we would do and only bump NumPy up to 1.17. However, let's also plan on adopting either NEP 29 or SPEC 0. Hopefully, they'll be the same recommendation, but if they differ, it depend on when SPEC 0 gets finalized. (For simplicity, to avoid changing our policy twice if we can do that in a good timeframe, like this year.)

Also, don't merge this one yet. I'd like to do a final patch release of 2.0 without this PR, so that this is the only change from the last 2.0 to the first 2.1 (in case it makes somebody's debugging task easier...).

@jpivarski jpivarski added the pr-on-hold This PR is inactive due to a pending decision or other constraint label Mar 6, 2023
@jpivarski
Copy link
Member

The pr-on-hold label will only be on this until we're ready for the 2.0 → 2.1 transition, which could be as early as today.

@jpivarski jpivarski added pr-on-hold This PR is inactive due to a pending decision or other constraint and removed pr-on-hold This PR is inactive due to a pending decision or other constraint labels Mar 6, 2023
@jpivarski jpivarski merged commit 5ab92ef into main Mar 7, 2023
@jpivarski jpivarski deleted the agoose77/chore-bump-numpy-version branch March 7, 2023 19:21
@jpivarski jpivarski removed the pr-on-hold This PR is inactive due to a pending decision or other constraint label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants