Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not expose an rdfentry_ column #2343

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Mar 29, 2023

Fixes unintentional exposure of an rdfentry_ column. There is no test to check it, but current documentation shows that an rdfentry_ column was exposed:

array = ak.from_rdataframe(
    df,
    columns=(
        "x",
        "y",
        "z",
    ),
)
array

[{y: 1, z: [1.1], rdfentry_: [0, 1, 2, 3, 4], x: {...}},
 {y: 2, z: [2.1, 2.3, 2.4], rdfentry_: [0, 1, ..., 3, 4], x: {...}},
 {y: 3, z: [3.1], rdfentry_: [0, 1, 2, 3, 4], x: {...}},
 {y: 4, z: [4.1, 4.2, 4.3], rdfentry_: [0, 1, ..., 3, 4], x: {...}},
 {y: 5, z: [5.1], rdfentry_: [0, 1, 2, 3, 4], x: {...}}]
--------------------------------------------------------------------
type: 5 * {
    y: int64,
    z: var * float64,
    rdfentry_: var * int64,
    x: {
        x: var * float64
    }
}

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2343 (a789288) into main (1f70725) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/numexpr.py 90.27% <ø> (ø)
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/highlevel.py 75.79% <0.00%> (-0.25%) ⬇️

@ianna ianna temporarily deployed to docs-preview March 29, 2023 10:49 — with GitHub Actions Inactive
@ianna ianna changed the title fix: do not expose rdfentry_ column fix: do not expose an rdfentry_ column Mar 29, 2023
@ianna ianna requested a review from jpivarski March 29, 2023 11:20
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good—separating the index out into something distinct from columns, as it would be in (for example) Pandas.

Merge the branch whenever you're ready!

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good—separating the index out into something distinct from columns, as it would be in (for example) Pandas.

Merge the branch whenever you're ready!

@ianna ianna merged commit 60bec22 into main Mar 29, 2023
@ianna ianna deleted the ianna/rdataframe-hide-rdfentry-column branch March 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants