fix: make from_iter require iterables!
#2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
jpivarski
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Just comments for now because I'm a little wary of this one. I get that you're trying to make the function name more literal, and therefore more guessable without recourse to the documentation. I'm hesitant because there might be some things people expect would work, even though they're not literally iterables.
If the tests pass, then if there are any such cases, they're not explicitly being tested.
agoose77
force-pushed
the
agoose77/fix-from-iter-non-iterable
branch
from
e23ff71 to
8c48428
Compare
jpivarski
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
from_itercan understand non-iterables, I think we really want to restrict it to only returning layouts/arrays.