Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added kernel specializations for awkward_ListOffsetArray_reduce_local_nextparents_64 #2572

Conversation

jpivarski
Copy link
Member

This includes the awkward-cpp version number bump. Before we make another awkward release, we'll need the new awkward-cpp release, but the tests will warn us about that.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2572 (5fa7101) into main (01cd79f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/listoffsetarray.py 81.01% <100.00%> (+0.10%) ⬆️

@agoose77 agoose77 changed the title fix: added kernel specializations for awkward_ListOffsetArray_reduce_local_nextparents_64. fix: added kernel specializations for awkward_ListOffsetArray_reduce_local_nextparents_64 Jul 5, 2023
@agoose77 agoose77 enabled auto-merge (squash) July 5, 2023 18:25
@agoose77 agoose77 self-requested a review July 5, 2023 18:25
@jpivarski
Copy link
Member Author

Okay, thanks! (I didn't want to bother you.)

@agoose77 agoose77 disabled auto-merge July 5, 2023 18:27
@agoose77
Copy link
Collaborator

agoose77 commented Jul 5, 2023

@jpivarski not at all! But I appreciate it.

Just making a quick change that I noticed...

@agoose77 agoose77 enabled auto-merge (squash) July 5, 2023 18:30
@jpivarski
Copy link
Member Author

I think those are unrelated to this fix, but also necessary. Thanks for noticing them!

@agoose77 agoose77 temporarily deployed to docs-preview July 5, 2023 18:37 — with GitHub Actions Inactive
@agoose77 agoose77 merged commit 44b0c3e into main Jul 5, 2023
@agoose77 agoose77 deleted the jpivarski/kernel-specializations-for_awkward_ListOffsetArray_reduce_local_nextparents_64 branch July 5, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awkward_ListOffsetArray_reduce_local_nextparents_64 only supports int64 arguments
2 participants