Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buffer_key to typetracer_with_report #2719

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

agoose77
Copy link
Collaborator

This PR makes it possible to format the form_keys assigned to typetracer buffers via ak.typetracer.typetracer_with_report. Although the default behaviour is unchanged, this permits us to ensure that buffer keys are unique within a typetracer layout.

@agoose77 agoose77 marked this pull request as ready for review September 22, 2023 09:38
@agoose77 agoose77 requested a review from jpivarski September 22, 2023 09:38
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2719 (3f40f00) into main (01a1deb) will increase coverage by 0.02%.
The diff coverage is 60.00%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/_nplikes/typetracer.py 77.06% <52.94%> (+0.76%) ⬆️
src/awkward/typetracer.py 87.50% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

@agoose77 agoose77 temporarily deployed to docs-preview September 22, 2023 09:51 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview September 22, 2023 12:01 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, at the time that (public function) typetracer_with_report is called, we assume that users already know what buffer_key function they'll want to use? That does sound reasonable.

Merge when you're ready!

@agoose77 agoose77 merged commit 2a70afb into main Sep 22, 2023
@agoose77 agoose77 deleted the agoose77/feat-typetracer-with-report-buffer-key branch September 22, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants