Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ak.to_categorical #2779

Merged
merged 1 commit into from
Nov 5, 2023
Merged

chore: remove ak.to_categorical #2779

merged 1 commit into from
Nov 5, 2023

Conversation

agoose77
Copy link
Collaborator

This follows our planned removal in 2.5.0

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #2779 (62baa96) into v2.5.0-rc-feature (4ed2397) will increase coverage by 0.04%.
Report is 17 commits behind head on v2.5.0-rc-feature.
The diff coverage is n/a.

❗ Current head 62baa96 differs from pull request most recent head fb1e82d. Consider uploading reports for the commit fb1e82d to get more accurate results

Additional details and impacted files
Files Coverage Δ
src/awkward/operations/__init__.py 100.00% <ø> (ø)
src/awkward/operations/ak_categories.py 100.00% <ø> (ø)
src/awkward/operations/ak_from_categorical.py 95.23% <ø> (ø)
src/awkward/operations/ak_is_categorical.py 100.00% <ø> (ø)

... and 65 files with indirect coverage changes

@agoose77 agoose77 requested a review from jpivarski October 30, 2023 14:21
jpivarski
jpivarski approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's on the list, so it's time for it to go!

@agoose77 agoose77 mentioned this pull request Oct 30, 2023
Closed
@agoose77 agoose77 added the pr-on-hold This PR is inactive due to a pending decision or other constraint label Nov 3, 2023
@agoose77 agoose77 changed the base branch from main to v2.5.0-rc-feature November 5, 2023 14:59
@agoose77 agoose77 force-pushed the agoose77/chore-remove-to-categorical branch from 62baa96 to fb1e82d Compare November 5, 2023 15:00
@agoose77 agoose77 force-pushed the v2.5.0-rc-feature branch 2 times, most recently from fb61ff9 to 3195e63 Compare November 5, 2023 15:02
@agoose77 agoose77 merged commit 49d3dd0 into v2.5.0-rc-feature Nov 5, 2023
@agoose77 agoose77 deleted the agoose77/chore-remove-to-categorical branch November 5, 2023 15:02
agoose77 added a commit that referenced this pull request Nov 6, 2023
@agoose77
chore: remove to_categorical (#2779)
be3cbe0
agoose77 added a commit that referenced this pull request Nov 7, 2023
@agoose77
feat!: prepare for 2.5.0 (#2798)
bd4cb8d 
* fix: drop lengths recursively (#2775)

* fix: drop lengths recursively

* test: ensure slicing from-typetracer works

* chore: bump pyproject.toml

* chore: remove to_categorical (#2779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
pr-on-hold This PR is inactive due to a pending decision or other constraint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski