fix: include _kernel_signatures.py in package
#2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
_kernel_signatures.py in package
|
I fully tested this on a private repo, but a subtle configuration difference meant that when switching to |
jpivarski
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
I haven't personally tested this (I don't currently have Docker), but it doesn't affect mainline Awkward and can be fixed later if it needs to be generalized beyond the one computer where it was tested (@agoose77's).
The pyproject.toml is changed, but these are corrections (including /src/awkward/_connect/cuda/_kernel_signatures.py).
Go ahead and merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a Docker container to run our GPU tests using systemd, with the intention that errors can be reported as GitHub issues.
In doing so, I noticed that we weren't including the CUDA kernel signatures in our built packages, so non-development installs weren't getting these. Another problem associated with not testing our installs :(
This PR also fixes an API breakage in the
tracebackmodule that is not super-clear from the docs — the base image I'm using from NVidia uses Python 3.8 which surfaced our misusage in the CUDA tests.