-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Indexed builder #2883
Conversation
354e19e
to
6d31acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved this on zonca#3, and see that it's the same Indexed
Builder implementation here.
This doesn't have the
- cmake -B build -S header-only -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=bin -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=ON
+ cmake -B build -S header-only -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=bin -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON
update in .github/workflows/header-only-test.yml, but that's unrelated to adding the new Builder, so it's best not to have it in the PR, anyway. Everything else looks goo. (The zonca#3 was a difference after IndexedOption
had been copied to Indexed
, but this is a more direct addition.)
I'll merge it when the tests pass.
We only need one approval for merging. Last time, @ManasviGoyal also approved it, anyway. |
right, that was already merged back in #2870 |
@all-contributors please add @zonca for code |
I've put up a pull request to add @zonca! 🎉 |
As discussed with @jpivarski and @ManasviGoyal, here is the implementation of the Indexed layout builder.
The final objective is to use this for
EnumType
instead of usingNumpyBuilder
.