Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update actions/(upload|download)-artifact #2904

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 15, 2023

This PR updates our various CI actions and reworks the packaging test workflow.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6d6f5c) 81.98% compared to head (91cb713) 81.98%.

Additional details and impacted files

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an upgrade to upload-artifact@v4 and changing some names. That's all good, though we'll need to change the set of required tests, which will affect everyone with an open PR.

So, it's not ready to merge until we coordinate with everyone who has an open PR.

(I'll be out of touch until Sunday.)

@agoose77 agoose77 enabled auto-merge (squash) December 19, 2023 21:30
@agoose77 agoose77 disabled auto-merge December 19, 2023 21:54
@agoose77 agoose77 merged commit 1cc22e5 into main Dec 19, 2023
38 checks passed
@agoose77 agoose77 deleted the agoose77/ci-separate-artifacts branch December 19, 2023 21:54
@agoose77
Copy link
Collaborator Author

agoose77 commented Dec 19, 2023

I updated the branch status checks using

commit="<SOME-SHA-WITH-NEW-CHECKS>"
# Read checks
gh api repos/scikit-hep/awkward/commits/${commit}/check-runs --paginate --jq '{ context: .check_runs[].name }' | jq -s '{ checks: . | unique }' > /tmp/checks.json
# Remove the check pertaining to docs deployment (skipped for PRs)
$EDITOR /tmp/checks.json
# Patch checks
gh api repos/scikit-hep/awkward/branches/main/protection/required_status_checks \
  --method PATCH \
  --input /tmp/checks.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants