Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: new cuda kernels #2922

Merged
merged 19 commits into from
Mar 28, 2024
Merged

test: new cuda kernels #2922

merged 19 commits into from
Mar 28, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

No description provided.

@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (b749e49) to head (a3c59e7).
Report is 50 commits behind head on main.

❗ Current head a3c59e7 differs from pull request most recent head 4957c34. Consider uploading reports for the commit 4957c34 to get more accurate results

Additional details and impacted files

@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/tests-for-cuda-kernels branch from a3c59e7 to f668fc5 Compare February 26, 2024 08:11
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/tests-for-cuda-kernels branch 2 times, most recently from 0ff16ae to a175ff4 Compare March 21, 2024 08:23
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/tests-for-cuda-kernels branch from a175ff4 to bf9e269 Compare March 21, 2024 10:30
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have all these tests, which indicate which high-level functions are working now and ensure that they won't stop working as long as we run tests on a computer with a GPU.

I ran the tests on my GPU:

tests-cuda/test_1276_cuda_num.py .........             [  5%]
tests-cuda/test_1276_cuda_transfers.py ............... [ 14%]
.                                                      [ 14%]
tests-cuda/test_1276_cupy_interop.py .                 [ 15%]
tests-cuda/test_1276_from_cupy.py .....                [ 18%]
tests-cuda/test_1300_same_for_numba_cuda.py .......... [ 24%]
.............                                          [ 31%]
tests-cuda/test_1381_check_errors.py .                 [ 32%]
tests-cuda/test_1809_array_cuda_jit.py ..............  [ 40%]
tests-cuda/test_2922a_new_cuda_kernels.py ............ [ 47%]
...................................................... [ 79%]
....                                                   [ 82%]
tests-cuda/test_2922b_new_cuda_kernels.py ............ [ 89%]
..................                                     [100%]

==================== 169 passed in 9.44s =====================

So this is ready to merge! Since I know you won't be adding anything more today, I'll merge it. Any more tests should go into a new PR.

tests-cuda/test_1276_cuda_num.py Show resolved Hide resolved
@jpivarski jpivarski merged commit 217b3ea into main Mar 28, 2024
38 checks passed
@jpivarski jpivarski deleted the ManasviGoyal/tests-for-cuda-kernels branch March 28, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants