-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DressedType with parameters on all the Types. #32
Merged
jpivarski
merged 54 commits into
master
from
feature/replace-dressedtype-with-parameters
Dec 13, 2019
Merged
Replace DressedType with parameters on all the Types. #32
jpivarski
merged 54 commits into
master
from
feature/replace-dressedtype-with-parameters
Dec 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type: need to change their signatures to accomodate.
…cepts still works.
…e does. (Get rid of FillableArray::type? It's redundant because you can always take a snapshot.)
jpivarski
changed the title
[WIP] Replace DressedType with parameters on all the Types.
Replace DressedType with parameters on all the Types.
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
DressedType
a newType
object complicates the hierarchy (different structure than the bare type). EachType
has an (unused)parameters
, which should instead be used to augment the existingType
objects in an unchanged hierarchy.The wrapper class (currently the "dress") can become an entry in the
parameters
named__class__
, and this leaves room for a Numba wrapper and higher-array wrapper classes.The
Dress
andPyDress
classes should go away, but theParameters
andPyParameters
stay. All of the existingTypes
must now be templated on theParameters
type. Its parameters should probably becomestd::map<std::string, py::object>
rather thanpy::dict
so that the parameter names, at least, can be inspected on the C++ side. Because of Numba (#31), all of those Python objects need to be hashable and pickleable, so there's a natural serialization that can be performed on the C++ side (becausePyParameters
defines the picklization into bytestrings).