Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep __getitem__ in C++. #8

Merged
merged 128 commits into from
Sep 21, 2019
Merged

Deep __getitem__ in C++. #8

merged 128 commits into from
Sep 21, 2019

Conversation

jpivarski
Copy link
Member

Let's do the C++ and the Numba in separate PRs.

@jpivarski
Start on PR7, deep __getitem__, for real this time.
943fe30
@jpivarski
Added Content::minmax_depth, which will be used by Ellipsis.
d2ab7dc
@jpivarski
[skip ci] writing.
ed0b57e
@jpivarski
Slices and RawArray compile.
f5eb87d
@jpivarski
[skip ci] Update the README.
2b872a0
@jpivarski
[skip ci] What about this link?
032a72f
@jpivarski
[skip ci] What about this link?
42521a0
@jpivarski
[skip ci] Finalized README.
638585a
@jpivarski
Add a C++ test of RawArray so we can test this without the full cycle.
1f9b88b
@jpivarski
[skip ci] Have to re-think Slices.
ff7d801
@jpivarski
Defined slices.
ea4fd46
@jpivarski
Poking around, I decided that I should learn how to do slicing on Num…
a097a16 
…pyArray, not RawArray (because NumpyArray supports multiple dimensions).
@jpivarski
To do the testing in Python, we'll need to convert all of the slice t…
91ea23b 
…ypes to C++.
@jpivarski
Don't actually raise exceptions while testing.
3b6869a
@jpivarski
[skip ci] working on it.
804dc16
@jpivarski
All Slice types should be readable now.
0942429
@jpivarski
Make syntax of test okay for Python 2.7.
6bf5006
@jpivarski
Make syntax of test okay for Python 2.7 (one more instance).
b834073
@jpivarski
Figure out what Windows uses as integer format strings.
e9b4b7c
@jpivarski
Intentionally fail so that we can see the format string explicitly on…
1610532 
… Windows.
@jpivarski
Should be fixed for Windows.
0a73ed8
@jpivarski
Another test for Windows.
de74fa9
@jpivarski
It's safest to let pybind11 decide if it needs to cast.
478a6fd
@jpivarski
Give NumpyArray a nice representation for common numerical types.
407e5e7
@jpivarski
Started on the true getitem.
50f6a29
@jpivarski
Working on chaining getitems.
d8d18f7
@jpivarski
[skip ci] Interaction between SliceAt and SliceStartStop is starting …
2f6ea5b 
…to work.
@jpivarski
Most of getitem has been implemented for SliceAt and SliceStartStop.
6cd7c81
@jpivarski
Consolidated and cleaned up.
42ba7e2
@jpivarski
But don't intentionally raise an Exception.
b7f2ec1
@jpivarski
Fix 32-bit compilation.
d59fcb9
@jpivarski
[skip ci] working on slice bystrides
b22ecf4
@jpivarski
[skip ci] slices might be working
f5ec8fe
@jpivarski
The new getitem is tested for integer and slice.
76ba396
@jpivarski
Short-circuited NumpyArray::get and NumpyArray::slice through NumpyAr…
e31b34a 
…ray::getitem, but IDs will need to be propagated through it.
@jpivarski
Fix 32-bit Windows.
703c037
@jpivarski
The experimental getitem became standard __getitem__.
6df2940
@jpivarski
NumpyArray::getitem_bystrides.
52aff06
@jpivarski
Fix Python 2.7.
d774273
@jpivarski
Starting onto NumpyArray::contiguous.
590c16e
@jpivarski
[skip ci] working on contiguous
fae177e
@jpivarski
Contiguous is working.
1f4d331
@jpivarski
Stub of NumpyArray::getitem_next compiles.
dbd8175
@jpivarski
getitem_next null in progress
711da56
@jpivarski
One level of getitem_next is working.
1063d7a
@jpivarski
Two levels of getitem_next are working.
a125fcf
@jpivarski
Add boolean mask tests and fix integer size/signed warnings.
74c0e2b
@jpivarski
Empty index array is not a special case.
92fc9ab
@jpivarski
Slices in NumpyArray::getitem_next work.
957d279
@jpivarski
All cases in NumpyArray::getitem are covered.
95dd022
@jpivarski
Start moving functions to cpu-kernels and fix Python 2.7.
b5c50a2
@jpivarski
Moving more functions into cpu-kernels.
e1743cb
@jpivarski
Fixed a bug in contiguous.
f471578
@jpivarski
Moving more functions into cpu-kernels.
71b5f5a
@jpivarski
Finished moving functions into cpu-kernels.
c2a7e22
@jpivarski
Minimize '#include' scopes.
cd4ec30
@jpivarski jpivarski changed the title [WIP] Deep __getitem__ in C++. Deep __getitem__ in C++. Sep 21, 2019
@jpivarski jpivarski merged commit ecf83ca into master Sep 21, 2019
@jpivarski jpivarski deleted the feature/deep-getitem-2 branch September 21, 2019 17:26
jpivarski added a commit that referenced this pull request Sep 21, 2019
@jpivarski
[skip ci] README.md notes about PR #8.
76ce154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpivarski