feat: support custom colors for data/MC plots #399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
colors
argument tovisualize.data_mc
andvisualize.data_mc_from_histograms
(as well asvisualize.plot_model.data_mc
) that allows specifying color names per sample:colors={"signal": "red", "background": "blue"}
. Colors need to be provided for all samples, otherwise an exception is raised. If colors are invalid, an exception will later on be raised viamatplotlib
. The default behavior is unchanged, falling back to theseaborn-colorblind
colors.visualize.data_mc_from_histograms
was still missing thechannels
kwarg, this is now also included.resolves #381 (rest of that issue migrated to #265)