-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added length-0 fallback method for pytorch #1265
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Apart from the test failure which I'm sure you'll fix, I suggest that it's explicit in the docstring that I have one question though, why only do this for pytorch? How can we be sure that tensorflow, xgboost and triton are all fine with length-zero batches? |
For the other wrappers, there are alternate methods for obtaining the output dimensions rather than having the user specifying those, I'm looking into how to use those. Ideally, the various libraries should handle the length-0 situations themselves, so we probably just want a flag the enables fall back behavior is something fails. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Very close to being done, the only caveat is that the tensorflow model testing currently requires explicit unfolding to test (so it is an issue with data mangling for length-0 chunks). Still need to think a bit how best to add a proper test case for this. I am otherwise done with the code changes to the main package. |
Certain pytorch methods fail with length-0 inputs. Length-0 inputs are potentially common for low efficiency event selection, so here we provide a way for the user to specify what to return for length-0 inputs.