Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ruff to import annotations #1042

Merged
merged 3 commits into from
Nov 27, 2023
Merged

chore: use ruff to import annotations #1042

merged 3 commits into from
Nov 27, 2023

Conversation

lobis
Copy link
Collaborator

@lobis lobis commented Nov 22, 2023

No description provided.

@lobis lobis requested a review from agoose77 November 22, 2023 20:46
@lobis
Copy link
Collaborator Author

lobis commented Nov 22, 2023

@agoose77 do you know any rule to enforce a single line jump before imports, to avoid https://github.com/scikit-hep/uproot5/pull/1042/files#diff-7bf9f23c1473db1a176a044ec01de0b429c4f8c6c3998aa7496f0d834a8a1b9cR3-R4?

@agoose77
Copy link
Collaborator

@lobis I actually prefer that style. If you don't have strong feelings, I'd just leave it.

I'm not aware of any rule / configuration option to enforce this, but it doesn't mean that one doesn't exist. I had another look, and couldn't see anything that stands out to me.

@lobis
Copy link
Collaborator Author

lobis commented Nov 23, 2023

@lobis I actually prefer that style. If you don't have strong feelings, I'd just leave it.

I'm not aware of any rule / configuration option to enforce this, but it doesn't mean that one doesn't exist. I had another look, and couldn't see anything that stands out to me.

Sure, we can leave it as it is. I couldn't find anything either so it's probably something we shouldn't care about anyway.

@lobis lobis marked this pull request as ready for review November 23, 2023 02:22
@agoose77 agoose77 requested a review from jpivarski November 26, 2023 20:44
@jpivarski jpivarski merged commit 4112159 into main Nov 27, 2023
@jpivarski jpivarski deleted the import-annotations branch November 27, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants