chore: miscellaneous RNTuple improvements #1250
Merged
+620
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariostas
commented
Sep 5, 2024
This was
linked to
issues
Oct 4, 2024
|
@jpivarski this PR is ready for review now. Here are some highlights/comments:
|
jpivarski
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Very nice—I like the grouped enums! As far as I can see, these are maintainability updates, not changes in how the code functions. (Okay, I see that the PR title contains "chore:" rather than "feat:" or "fix:".)
Again, I'm forwarding you (email) the information about the RC3 format change, which is likely to be the last one ever.
Feel free to merge this PR!
pfackeldey
pushed a commit
to pfackeldey/uproot4
that referenced
this pull request
Jan 27, 2025
* Fixed __len__ method * Added a few more useful methods * Use the right number in arrays method * Updated to match spec and did some cleanup * Fixed order of extra type information * Extract column summary flags * style: pre-commit fixes * Fixed conflict resolution * Fixed test * Switched to using enums * Fixed RNTuple anchor * Updated locator types * Removed UserMetadata envelope * Started implementing new real32 types * Updated sharded cluster to match spec * Removed user metadata from footer * Fixed ClusterSummaryReader * Fix cascadentuple * Introduced RNTupleField class * Added test for scikit-hep#1285 * Fixed test * Fix test (attempt 2) * Finalized first version of RNTupleField * Added tests for RNTupleField * Implemented iterate method --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues in #1220. I fixed the
__len__method so that it returns the number of top-level columns instead of the number of entries, which is now thenum_entriesproperty.I'll work on implementing an
iteratemethod and update this description when it's ready.