Installation requirements and error text for dask/dask-awkward in extras.py #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Actually, |
kkothari2001
added a commit
that referenced
this pull request
Aug 24, 2022
jpivarski
added a commit
that referenced
this pull request
Aug 24, 2022
This also addresses #652 (comment), but is more up-to-date. It _replaces_ #680, which should be closed.
|
Replaced by #690. |
jpivarski
added a commit
that referenced
this pull request
Aug 24, 2022
This also addresses #652 (comment), but is more up-to-date. It _replaces_ #680, which should be closed.
jpivarski
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Token change to get PR number * Revert "Token change to get PR number" This reverts commit ce59fe1. * from_map optimization: Tests pass * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks" This reverts commit 6bc1c39. * Solve issues with merge and add 2 noqa's * Changes as suggested in #680 * Use right label for dask arrays * Import dask.blockwise in extras * Corrected issue with error message during merge * Remove specia keyword used in tests for assert_eq Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing #652 (comment) (@masonproffitt).
@kkothari2001, please make sure that
uproot.extras.dask_awkwardis only called iflibrary != "np"(i.e.uproot.daskwithlibrary="np"requires Dask, butuproot.daskwithlibrary="ak"requires Dask-Awkward). If Dask-Awkward strictly depends ondask[complete](I haven't checked: please check it!), then the imports in thedask_awkward()function can be reduced to justimport dask_awkward. We want to minimize the number of error messages that say, "Stop what you're doing and go install some other library," but not require people to install things that they don't need. (Consider the example oflz4andxxhash, which are always needed together, so the error message for both says to install both.)I'm not sure what will be required for the
library="pd"case; quite possibly Awkward-Pandas. (If we no longer explode ragged data into a MultiIndex but wrap them using Awkward-Pandas, as described in #668, then every function withlibrary="pd"may need Awkward-Pandas.)