fix: protect Uproot's 'project_columns' from Dask node names. #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
reviewed
Dec 15, 2022
Comment on lines
+600
to
+604
| return _UprootRead( | ||
| self.ttrees, | ||
| [x for x in branches if x in self.branches], | ||
| self.interp_options, | ||
| ) |
There was a problem hiding this comment.
This might need to be a set intersection, except it's likely not to be a significant performance bottleneck.
agoose77
approved these changes
Dec 15, 2022
jpivarski
deleted the
jpivarski/protect-uproot-project_columns-from-dask-node-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing Dask graphs with a operations inside a
__getitem__,Uproot is receiving names like "less-06b0b18209c65504e8506df9da02f75d" as branch names in
project_columns. The strings we get inproject_columnsshould be a strict subset of the strings in the input set of columns. This PR selects that subset, but it shouldn't be happening on the dask-awkward end.I'm using a version of dask-awkward from git...
7fe448a1d448fa30f09693be0b14634c7968161afrom December 9, 2022.