Rename and add member variables #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecers
force-pushed
the
fix/member_variables
branch
4 times, most recently
from
64a31ae to
d5f020e
Compare
rosecers
force-pushed
the
fix/member_variables
branch
from
d5f020e to
3ff1bab
Compare
agoscinski
reviewed
May 31, 2023
There was a problem hiding this comment.
Thanks for the work, it really simplifies reviewing! There is just one comment on the axis. Otherwise it is good to go. A suggestion for the final commit message
Renaming private member variables and updating tests
* Renaming private member variables marked as private to sklearn style
* Adding n_samples_in_, self.n_features_in_ to sklearn classes
* tests/test_feature_pcov_cur.py Adding target y to fitting for consistency
* tests/test_greedy_selector.py Removing unnecessary selector_sample fit and update error message
* tests/test_kernel_pcovr.py Adding tests for different solvers
* tests/test_orthogonalizers.py Fix small doc typo
4019b35 to
1265be3
Compare
agoscinski
approved these changes
Jun 1, 2023
|
Suggestion for commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, the portions of #196 that only deal with renaming member variables. I tried my best to keep it as clean as possible, but it is a large change.
📚 Documentation preview 📚: https://scikit-matter--197.org.readthedocs.build/en/197/